perf(rsc): use srvx/node in dev and preview
#964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for PR. Some tests are failing. I'm not sure yet whether this is due to srvx or something inherent on our test suites. |
Contributor
Author
|
Cool, now tests are passing 😄 The Issue was with the abort signal firing now we do it similar to Bun. If you run tests with Deno (native server) i guess they would fail. |
pi0
commented
Dec 11, 2025
Co-authored-by: Pooya Parsa <[email protected]>
hi-ogawa
approved these changes
Dec 12, 2025
Contributor
hi-ogawa
left a comment
hi-ogawa
left a comment
There was a problem hiding this comment.
Great, thanks for looking into it!
hi-ogawa
changed the title
srvx/node in devsrvx/node in dev and preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates
plugin-rscto usesrvx/nodein dev mode for fetch=>node handler compatibility.srvx perf is almost close to native and adopted by several projects (h3, nitro, nuxi, elysia, tanstack start, vercube, ...)